Fix warnings

lief-project · Nov 9, 2023 · 77b94c0 · 77b94c0
1 parent fcf5dae
commit 77b94c0
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 9 deletions.
diff --git a/.github/workflows/osx.yml b/.github/workflows/osx.yml
@@ -33,6 +33,7 @@ jobs:
       - name: Build SDK
         shell: bash
         env:
+          CLICOLOR_FORCE: "1"
           MACOSX_DEPLOYMENT_TARGET: "11.0"
           CCACHE_DIR: ${{ runner.temp }}/.ccache
           CCACHE_MAXSIZE: 10.0G
@@ -99,6 +100,8 @@ jobs:
           LIEF_BUILD_DIR: "/tmp/lief-build"
           PYLIEF_CONF: "${{ github.workspace }}/scripts/osx/osx-testing-x64.toml"
           CLICOLOR_FORCE: "1"
+          PYTEST_ADDOPTS: "--color=yes"
+          FORCE_COLOR: "1"
           MACOSX_TARGET: "11.7"
           MACOSX_DEPLOYMENT_TARGET: "11.0"
           CCACHE_DIR: ${{ runner.temp }}/.ccache
@@ -165,6 +168,8 @@ jobs:
         shell: bash
         env:
           MACOSX_DEPLOYMENT_TARGET: "11.0"
+          FORCE_COLOR: "1"
+          CLICOLOR_FORCE: "1"
           CCACHE_DIR: ${{ runner.temp }}/.ccache
           CCACHE_MAXSIZE: 10.0G
           CCACHE_CPP2: 1

diff --git a/src/BinaryStream/ASN1Reader.cpp b/src/BinaryStream/ASN1Reader.cpp
@@ -48,7 +48,6 @@ result<bool> ASN1Reader::is_tag(int tag) {
 result<size_t> ASN1Reader::read_tag(int tag) {
   size_t out = 0;
 
-  const uint8_t* cur_p = stream_.p();
   uint8_t* p           = stream_.p();
   const uint8_t* end   = stream_.end();
 

diff --git a/src/ELF/Builder.tcc b/src/ELF/Builder.tcc
@@ -1590,7 +1590,6 @@ ok_error_t Builder::build_symbol_definition() {
   using Elf_Half    = typename ELF_T::Elf_Half;
   using Elf_Word    = typename ELF_T::Elf_Word;
   using Elf_Addr    = typename ELF_T::Elf_Addr;
-  using Elf_Off     = typename ELF_T::Elf_Off;
 
   using Elf_Verdef  = typename ELF_T::Elf_Verdef;
   using Elf_Verdaux = typename ELF_T::Elf_Verdaux;

diff --git a/src/ELF/Parser.tcc b/src/ELF/Parser.tcc
@@ -172,9 +172,9 @@ ok_error_t Parser::parse_binary() {
       }
 
       if (auto res = binary_->virtual_address_to_offset(virtual_address)) {
-        auto parsing_result = type == DYNAMIC_TAGS::DT_RELA ?
-                              parse_pltgot_relocations<ELF_T, typename ELF_T::Elf_Rela>(*res, size) :
-                              parse_pltgot_relocations<ELF_T, typename ELF_T::Elf_Rel>(*res, size);
+        type == DYNAMIC_TAGS::DT_RELA ?
+                parse_pltgot_relocations<ELF_T, typename ELF_T::Elf_Rela>(*res, size) :
+                parse_pltgot_relocations<ELF_T, typename ELF_T::Elf_Rel>(*res, size);
         binary_->sizing_info_->jmprel = size;
       } else {
         LIEF_WARN("Can't convert DT_JMPREL.virtual_address into an offset (0x{:x})", virtual_address);

diff --git a/src/MachO/Parser.cpp b/src/MachO/Parser.cpp
@@ -212,7 +212,9 @@ ok_error_t Parser::undo_reloc_bindings(uintptr_t base_address) {
   for (std::unique_ptr<Binary>& bin : binaries_) {
     for (Relocation& reloc : bin->relocations()) {
       if (RelocationFixup::classof(reloc)) {
-        auto& fixup = static_cast<RelocationFixup&>(reloc);
+        /* TODO(romain): We should support fixup
+         * auto& fixup = static_cast<RelocationFixup&>(reloc);
+         */
       }
       else if (RelocationDyld::classof(reloc)) {
         span<const uint8_t> content = bin->get_content_from_virtual_address(reloc.address(), sizeof(uintptr_t));

diff --git a/src/MachO/utils.cpp b/src/MachO/utils.cpp
@@ -197,9 +197,7 @@ bool check_valid_paths(const Binary& binary, std::string* error) {
       case LOAD_COMMAND_TYPES::LC_ID_DYLIB:
         {
           has_install_name = true;
-          /*
-           * Fallback
-           */
+          [[fallthrough]];
         }
       case LOAD_COMMAND_TYPES::LC_LOAD_DYLIB:
       case LOAD_COMMAND_TYPES::LC_LOAD_WEAK_DYLIB: