Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clippy suggests !('\u{fe00}'..='\u{fe0f}').contains(&ch) instead of (ch < '\u{fe00}' || ch > '\u{fe0f}') I disagree, because: * It adds more line noise (negation, &ch instead of ch). * It's hard to read (no space around character literals, which are already cluttered by the \ and {}, it becomes a line full of sigils.) * It uses the arcane ..= syntax that is relatively recent and very uncommon. Readers are not likely to know what it means. * It calls a method on a range, which is also somewhat arcane. It makes sense, but I think it is less obvious to a reader who may not know Rust as well, as plain comparisons that exist in any language. * "Inclusive range does not contain" does not feel obviously simpler to me than "outside of these bounds". For integer literals it might make sense, but in this case the suggestion looks like code golfing to me. It is also longer.
- Loading branch information