New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft of signalling escrow rotation feature #198

Draft

Psirex wants to merge 1 commit into develop from feature/signalling-escrow-rotation

Contributor

Psirex commented Nov 18, 2024

No description provided.


          Draft of signalling escrow rotation feature

13aef4d

github-advanced-security bot found potential problems

View reviewed changes

contracts/Escrow.sol

Comment on lines +271 to +275

+                  function recoverStETH() external returns (uint256 unlockedStETHShares) {
+                      _escrowState.checkRotatedEscrow();
+                      unlockedStETHShares = _accounting.accountStETHSharesUnlock(msg.sender).toUint256();
+                      ST_ETH.transferShares(msg.sender, unlockedStETHShares);
+                  }

Check warning

Code scanning / Slither

Unused return Medium

Escrow.recoverStETH() ignores return value by ST_ETH.transferShares(msg.sender,unlockedStETHShares)

contracts/Escrow.sol

Comment on lines +277 to +282

+                  function recoverWstETH() external returns (uint256 wstETHUnlocked) {
+                      _escrowState.checkRotatedEscrow();
+                      SharesValue unlockedStETHShares = _accounting.accountStETHSharesUnlock(msg.sender);
+                      wstETHUnlocked = WST_ETH.wrap(ST_ETH.getPooledEthByShares(unlockedStETHShares.toUint256()));
+                      WST_ETH.transfer(msg.sender, wstETHUnlocked);
+                  }

Check failure

Code scanning / Slither

Unchecked transfer High

Escrow.recoverWstETH() ignores return value by WST_ETH.transfer(msg.sender,wstETHUnlocked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet