Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix alternative castling #596

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix alternative castling #596

merged 4 commits into from
Mar 18, 2024

Conversation

HaonRekcef
Copy link
Contributor

@HaonRekcef HaonRekcef commented Mar 11, 2024 •
edited
Loading

fixes #593 #601 #602

@HaonRekcef HaonRekcef closed this Mar 11, 2024
@HaonRekcef HaonRekcef reopened this Mar 11, 2024
@HaonRekcef HaonRekcef mentioned this pull request Mar 14, 2024
Closed
veloce
veloce reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a test case to prevent further regression. Thanks!

lib/src/model/common/node.dart Outdated Show resolved Hide resolved
@HaonRekcef
Copy link
Contributor Author

I added a testcase, which fails with the old code and works with my bug fix. I tested the fix in the analysis screen and for the puzzles, in both cases it seems to fix the wrong behaviour. So #601 and #602 can be closed as well.
The checks for this pull request fail because some unrelated code features are deprecated in the newest flutter beta build.

This was referenced Mar 14, 2024
Closed
Closed
@HaonRekcef HaonRekcef requested a review from veloce March 14, 2024 22:57
@veloce
Copy link
Contributor

veloce commented Mar 15, 2024

Damn this bug is annoying. Unfortunately I won't be able to deal with it before 1 month when I return from my vacation.

If you want to, you can fix the flutter beta issues in another PR. We'd then be able to make a hot fix release for at least android users.

@HaonRekcef
Copy link
Contributor Author

HaonRekcef commented Mar 15, 2024 •
edited
Loading

Ok, I fixed it in #603. Enjoy your well deserved vacation!

@veloce
Copy link
Contributor

veloce commented Mar 18, 2024

Hi @HaonRekcef

If you commit the version change 7.0.5 to the pubspec.yaml file in this PR I can release the fix for all android users. Better than nothing I think 🙂

@HaonRekcef
Copy link
Contributor Author

I agree, I committed it, @veloce

@HaonRekcef
bump version
94dca22 
Revert "bump version"

This reverts commit 39ceac0.

bump version
@veloce
Copy link
Contributor

veloce commented Mar 18, 2024

Thank you!

@veloce veloce merged commit 7c7c9d8 into lichess-org:main Mar 18, 2024
3 checks passed
@HaonRekcef HaonRekcef deleted the fix-castlingmove branch March 18, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce Awaiting requested review from veloce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong move gets played in the analysis board
2 participants
@HaonRekcef @veloce