User full game list

[ZTL-UwU]

TODO

• Full game list (Full game list of a user with filters #454)
  • Infinite scroll
  • Lazy loading
  • Context menu
  • Bookmark / Unbookmark
    • Add slidable
    • Implement bookmark action
  • Filtering

Current status

[ZTL-UwU]

Currently we are downloading all game histories at once, which takes a very long time to load on startup if the user has a large number of games. We will need a pagination api to get a few games everytime.

[veloce]

Hello! Pagination is indeed mandatory, even for a first version.

[ZTL-UwU]

Pagination is now implemented! 🚀

[ijm8710]

Hello @ZTL-UwU, accuracy should prob be fetched as well similar to the recent game list, thoughts?

[ZTL-UwU]

Hello @ZTL-UwU, accuracy should prob be fetched as well similar to the recent game list, thoughts?

The accuracy should be fetched, yes. Problem is that the server API only return a "analysed": true instead of the full game analysis like the one used recent game list. I believe that getting the accuracy would require a change in the lila server.

[veloce]

@ZTL-UwU I think we should merge this PR with its current implementation (so without filters and bookmark action).

The rest can be done later. Could you resolve the conflicts please, then I'll review asap. Thanks!

[veloce]

Thanks for making the change @ZTL-UwU , I just realised you updated the PR. Will take take of it now.

[veloce]

It is starting to look good now!

As you may have noticed, now the recent games section include offline games too. Pagination support is already done in the GameStorage class, so it should be pretty straightforward now to include the offline games in full game list when having no connectivity.
Using same logic as in

mobile/lib/src/view/user/recent_games.dart

Line 57 in 60530a1

final recentGames = user != null

[veloce]

Thanks for your work. I pushed some refactoring, I'll continue to work a bit on it but I think we're close to merging this :)

[veloce]

By the way, each time I push to a remote repository branch, it messes up the diff. I don't know what I'm doing wrong...
I used this command to push the code to your repo:

git push [email protected]:ZTL-UwU/mobile.git ZTL-UwU-full-game-list:full-game-list

EDIT: oh, I suppose it is because of the merge commit. But GitHub command line instructions doesn't work without it.

[veloce]

🎉

[ijm8710]

@ZTL-UwU how much effort would it be to have a similar game list view+more button for even more game history but on the perf cards themselves?

I know you were considering working on bookmarks but curious since you basically have built this already if applying to perf cards would be a quicker hit

Hoping you and Veloce agree it makes sense to have them there

[ZTL-UwU]

@ijm8710 I thinks there is a merged PR for this already #830