Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android system colors #565

Merged
merged 14 commits into from
Feb 22, 2024
Merged

Android system colors #565

merged 14 commits into from
Feb 22, 2024

Conversation

veloce
Copy link
Contributor

@veloce veloce commented Feb 20, 2024

Closes #560
Closes #558

  • Adds a new settings entry to choose palette (only on android 12+):
  • Adds a new board theme settings entry (on android 12+):
  • Improve settings icons
  • Improve android launcher icons, add the monochrome variant

@veloce
Copy link
Contributor Author

veloce commented Feb 20, 2024

I'm not sure how to make the best looking "system color" board.

The approach I used is pretty simple:

final darkSquare = Color(corePalette.primary.get(70));
final lightSquare = Color(corePalette.secondary.get(90));

It uses dimmed version of primary and secondary colors. There is maybe a way to improve that?

@LSeelig
Copy link

LSeelig commented Feb 20, 2024

It uses dimmed version of primary and secondary colors. There is maybe a way to improve that?

I am no expert, but from looking at the other board themes, I think it needs a lot more contrast. Both darker dark squares and lighter light squares.

You might also want to use the fixed color (see primary fixed and 'on primary fixed/variant' so the light/dark squares don't get inverted by switching between light and dark theme.

https://m3.material.io/styles/color/system/how-the-system-works

image

image

@veloce veloce force-pushed the android_system_colors branch from 82bbe4a to c13c6a8 Compare February 21, 2024 15:21
@veloce
Copy link
Contributor Author

veloce commented Feb 21, 2024

This is the best I could come up with.

The system color board looks nice with all the different wallpaper I tried, in my opinion.

For now I don't think I'll make it the default. I'm a bit reluctant because of the strong identify of the lichess brown board, and also because with the system colors the last move and selected square are not as much visible as with the stock boards.

The option to switch to system colors is quite visible in the settings screen so people who like that feature would find it easily.

Screenshot_1708529453
Screenshot_1708529423
Screenshot_1708529408
Screenshot_1708529276
Screenshot_1708529200
Screenshot_1708529186

@LSeelig
Copy link

LSeelig commented Feb 21, 2024

I like it alot. Might be open to future tweaks of the square highlight, though I don't know how I would make it better yet.

@LSeelig
Copy link

LSeelig commented Feb 21, 2024

I dug into the current themes. This purple theme is fairly similar my system color pallette. Square highlights are in shades of green, despite the purple squares. Could you get better contrast if you weren't trying to theme the highlights?

Screenshot_20240221_164458.png

Screenshot_20240221_164503.png

Screenshot_20240221_164514.png

Screenshot_20240221_164518.png

@veloce
Copy link
Contributor Author

veloce commented Feb 22, 2024

I have to theme the highlights, because I have to ensure the highlights are visible in any case. If I keep the default green highlights they won't be visible with green themes.

@veloce
Copy link
Contributor Author

veloce commented Feb 22, 2024

It's good to have a default system colors board, but you'll always get a better result with stock boards I think. That's why I let the users choose another board theme, even if they activate system colors. In your case you'd choose to use pink board with system palette to have the best out of it (here the board is an image and there's a diagonal shadow on each square).

@veloce veloce marked this pull request as ready for review February 22, 2024 10:57
@veloce veloce merged commit 4ef81ae into main Feb 22, 2024
3 checks passed
@veloce veloce deleted the android_system_colors branch February 22, 2024 11:02
@LSeelig
Copy link

LSeelig commented Feb 22, 2024

Understood. I think your end result is excellent and agree w.r.t. user choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Option (if not default) For Material You Theme [Android] Add Monochrome Icon
2 participants