Annotation symbols displayed on wrong square if castling

[HaonRekcef]

What is the problem?

Annotation symbols displayed on wrong square if castling was the last move

Steps to reproduce the bug

1. Find a game where castling is an inaccuracy, mistake or blunder
2. Go to analysis

What did you expect to happen?

The shape should be displayed on the square the king moved to

What happened instead?

The shape was displayed on the square the rook moved from

Device Info

Pixel 6a

Operating System Version

Android 14

Additional information

Screenshot

[okmsbun]

Yes I tested it and it seems wrong. It's not like Lischess.org. In fact, in different forms of castling, it is sometimes not shown at all. In the video below, when I do the same castling in different ways, 'annotation' is shown (incorrectly) in one and not shown at all in the other.

Here for that

mobile/lib/src/view/analysis/analysis_screen.dart

Line 317 in 3c6d110

annotations: currentNode.sanMove != null && annotation != null

than

mobile/lib/src/model/common/chess.dart

Line 42 in 3c6d110

const altCastles = {

and checking whether castling is done or not, it seems like it can be solved.

Screen_Recording_20240209_164821.mp4

[okmsbun]

When I leave the king to c8, the 'currentNode.nags' list ([]) here appears empty. This list should not be empty. The list should be the same as the list ([6]) that comes when the king is left on a8.

Game = https://lichess.org/407v1JxQ/black#29