Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Glue File & Prepare for Sf 17 #2

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

Disservin
Copy link
Contributor

this splits the glue file into individual source files, should make it easier to persist backwards compatibility when trying to add support for a new version

lmk what you think (should have the same behaviour but didn't test it)

@Disservin
Copy link
Contributor Author

Disservin commented Aug 20, 2024

i've also prepped a little branch for the upcoming sf 17 which at least builds but again not sure if it will run fine, see

Disservin/lila-stockfish-web@split-glue-file...Disservin:lila-stockfish-web:split-glue-file-sf17

something I'm also not quite sure about is if our newly added numa code will be problematic/has to skipped/disabled, see

official-stockfish/Stockfish#5285

@Disservin
Copy link
Contributor Author

fyi stockfish 17 to be released soon

official-stockfish/Stockfish#5566

@Disservin Disservin changed the title split glue file Split Glue File & Prepare for Sf 17 Sep 3, 2024
@schlawg
Copy link
Collaborator

schlawg commented Sep 4, 2024

Apologies for the delay, nobody had contributed to this repo before so I wasn't watching it.

These changes work for me. Thanks! I'm curious if there's been any discussion about an official stockfish wasm?

@schlawg schlawg merged commit f50e19d into lichess-org:master Sep 4, 2024
@Disservin
Copy link
Contributor Author

Disservin commented Sep 4, 2024

No worries ;)

I'm curious if there's been any discussion about an official stockfish wasm?

There's no ongoing discussion nor can I recall that there was one in the past.
Feel free to open a discussion here https://github.com/official-stockfish/Stockfish/discussions if you feel like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants