This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Use cargo-chef #549
Merged
Use cargo-chef #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-chef allows to split downloading and building dependencies from building the actual project. This allows docker to cache a layer that downloads and builds dependencies and rebuild only the project instead. This change reduced the incremental build for me by over 60% from 327s to 130s. Signed-off-by: Piotr Jastrzebski <[email protected]>
LucioFranco
reviewed
Jul 25, 2023
Comment on lines
+13
to
+16
| RUN cat rust-toolchain.toml | grep "channel" | awk '{print $3}' | sed 's/\"//g' > toolchain.txt \ | ||
| && rustup update $(cat toolchain.txt) \ | ||
| && rustup default $(cat toolchain.txt) \ | ||
| && rm toolchain.txt rust-toolchain.toml |
There was a problem hiding this comment.
Is this still needed? If the toolchain file is in the root of the cargo workspace it should pick it up?
There was a problem hiding this comment.
It is entirely possible. Let me check and get back to you :)
There was a problem hiding this comment.
Actually even if rust-toolchain.toml is picked up. Not running rustup update here will cause the toolchain to be installed on each step instead of installing it once so this way it's faster and cached better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-chef allows to split downloading and building dependencies from building the actual project. This allows docker to cache a layer that downloads and builds dependencies and rebuild only the project instead.
This change reduced the incremental build for me by over 60% from 327s to 130s.