Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audio buffer size configurable #52

Open
drfiemost opened this issue Oct 5, 2024 · 10 comments
Open

Make audio buffer size configurable #52

drfiemost opened this issue Oct 5, 2024 · 10 comments
Assignees
Milestone

Comments

@drfiemost
Copy link
Member

As the title says, add an ini setting to specify the buffer length in milliseconds.

@drfiemost drfiemost self-assigned this Oct 5, 2024
@drfiemost drfiemost added this to the 2.11 milestone Oct 5, 2024
@ruby-R53
Copy link
Contributor

ruby-R53 commented Oct 5, 2024

funny how i was about to open an issue mentioning exactly that lol

@ruby-R53
Copy link
Contributor

oh yeah, one other thing i forgot to mention is that increasing the audio buffer size in sidplayfp makes the register dump display skip some frames to match with that size (?), at least when using PulseAudio

can this be fixed or is it just some insignificant detail?

@drfiemost
Copy link
Member Author

Maybe we can use a separate thread to update the display...

@ruby-R53
Copy link
Contributor

yeah, would also help with display flickering as a bonus maybe

@drfiemost
Copy link
Member Author

Available on master, please test

@ruby-R53
Copy link
Contributor

yeah the display is getting updated every 250 ms apparently, on both out123 and PulseAudio builds

it seems to have helped a bit with libsidplayfp#161 tho', i can still notice some inconsistencies with Gordian_Tomb.sid but they're more subtle now

@ruby-R53
Copy link
Contributor

ruby-R53 commented Oct 15, 2024

UPDATE: i also noticed that when selecting/replaying a tune, you hear some of it sorta leaking out after that brief moment of silence between the tune selection, seems like it's trying to fill a 250 ms buffer in the process (?)

@ruby-R53
Copy link
Contributor

ruby-R53 commented Oct 22, 2024

when selecting/replaying a tune, you hear some of it sorta leaking out after that brief moment of silence between the tune selection

coming to think of it, maybe this was already happening before this buffer thing was changed? however, the buffer size was so small back then that it was almost unnoticeable

@drfiemost
Copy link
Member Author

yeah, I've noticed the same, will look into it.

drfiemost added a commit that referenced this issue Oct 24, 2024
@drfiemost
Copy link
Member Author

Is it better now after last change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants