-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL2 thread proxying fixes #5365
Conversation
This PR uses new APIs added in [emscripten-core/emscripten#9336](emscripten-core/emscripten#9336) to improve compatibility with USE_PTHREADS=1. Original PR: emscripten-ports/SDL2#127 By: @jakogut Reviewed by: Daft-Freak
I think some of the comments from the original PR still apply, though I still haven't really looked into emscripten's threading stuff... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cast warning and formatting comments. Also SDL_GetDisplayUsableBounds
has some more EM_ASM
s that were added after the original PR.
I hope I addressed the required changes. Can't follow about |
Yeah you should update |
@Daft-Freak Do we want to merge this and deal with SDL_GetDisplayUsableBounds separately, or should one of us add it to this PR? |
It's probably just |
I added the SDL_GetDisplayDisplayBounds stuff in ea7d530, so this is good to go now. |
thanks a lot @icculus 🙇♂️ |
Description
This PR uses new APIs added in emscripten-core/emscripten#9336 to improve compatibility with USE_PTHREADS=1.
Original PR: emscripten-ports/SDL2#127
By: @jakogut
Reviewed by: @Daft-Freak
This fix enables me to compile an executable using
-s USE_PTHREADS=1 -s USE_SDL=2
and not get the following error in the chromuim debug consoleWith the current patch applied the InfiniSim Simulator works 🎉
Existing Issue(s)