Support key composing (i.e. dead keys) in Wayland driver #4296
Conversation
There was a problem hiding this comment.
Excellent work on rebasing this! I dug into the web archive and unfortunately the only name I could dig up was "chw", no e-mail address or anything. It does look like this was taken from that Weston URL though, so I dunno...
In any case, this is just what I would have reviewed for the original patch.
|
Original bugzilla entry is https://bugzilla.libsdl.org/show_bug.cgi?id=3687 |
Based on an old patch by chw from the old Bugzilla issue tracker. Authored-by: chw
There was a problem hiding this comment.
Latest lgtm! That said I am absolutely clueless on how dead keys actually work, so as long as someone who knows what they're doing can verify that this is functional this is good to go.
Fixes #2488.
|
Just for reference, here's the xkbcommon documentation on compose keys: https://xkbcommon.org/doc/current/group__compose.html |
|
I tested this for a bit with my admittedly little knowledge of compose keys and was able to verify that this works as advertised. Should be good to merge. |
There was a problem hiding this comment.
This got stomped on a bit by #4303, so it needs a quick rebase. Since we're having to rebase, figured I'd do one more pass for any possible nits.
| /* | ||
| * See https://blogs.s-osg.org/compose-key-support-weston/ | ||
| * for further explanation on dead keys in Wayland. | ||
| */ |
There was a problem hiding this comment.
Looks like this link is pretty dead even on Wayback Machine, so we can probably replace this with the official documentation for dead keys.
| /* | |
| * See https://blogs.s-osg.org/compose-key-support-weston/ | |
| * for further explanation on dead keys in Wayland. | |
| */ | |
| /* See https://xkbcommon.org/doc/current/group__compose.html | |
| * for further explanation on dead keys in Wayland. | |
| */ |
| if (!(locale = SDL_getenv("LC_ALL"))) | ||
| if (!(locale = SDL_getenv("LC_CTYPE"))) | ||
| if (!(locale = SDL_getenv("LANG"))) | ||
| locale = "C"; |
There was a problem hiding this comment.
| if (!(locale = SDL_getenv("LC_ALL"))) | |
| if (!(locale = SDL_getenv("LC_CTYPE"))) | |
| if (!(locale = SDL_getenv("LANG"))) | |
| locale = "C"; | |
| if (!(locale = SDL_getenv("LC_ALL"))) { | |
| if (!(locale = SDL_getenv("LC_CTYPE"))) { | |
| if (!(locale = SDL_getenv("LANG"))) { | |
| locale = "C"; | |
| } | |
| } | |
| } |
…4296) Based on an old patch by chw from the old Bugzilla issue tracker. Authored-by: chw Co-authored-by: Sam Lantinga <[email protected]>
Based on an old patch (#2488) from the old Bugzilla issue tracker. Unfortunately, migration to Github erased the name so I can't properly attribute authorship.