fix(lxlweb): Continue showing error page for _invalid when not using Supersearch #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbissemattsson
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves
Frontend tests were failing because of API changes added in libris/librisxl#1541
Basically the lack of
@idfor an invalid property caused the 500 error page to show instead of expected 400.However, when fixing this and using 'old search' the resulting page for an invalid query is now this:
We figured as long as supersearch is not fully implemented, users still want some kind of feedback when using invalid queries. Therefore manually (temporarily) showing the same error page as before. This also makes tests pass.
ping @olovy @kwahlin
Summary of changes
InvalidProperty@idcheck in search.tssearch.ts, when encountering an_invalidproperty, show error page with same message as before.