Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lxlquery): Support wildcard in qualifierValue #1192

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(lxlquery): Support wildcard in qualifierValue #1192

merged 2 commits into from
Dec 20, 2024

Conversation

jesperengstrom
Copy link
Contributor

Description

Solves

  • Support a Wildcard as sole QualifierValue. For example 'Endast omslagsbild' filter image:*
  • Support a Wildcard ending QualifierValue identifier and number. For example title:kulturarv*
  • Also fixes syntax highlighting of BooleanOperator within a BooleanQuery.

Summary of changes

  • Update grammar
  • Update/add grammar test
  • Update tag highlighter
  • Update lxlquery.css

@jesperengstrom jesperengstrom marked this pull request as ready for review December 19, 2024 10:46
johanbissemattsson
johanbissemattsson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@johanbissemattsson johanbissemattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice! 🌟

@jesperengstrom jesperengstrom force-pushed the fix/lxlquery-wildcard-boolean-operator branch from df017d8 to a3025b4 Compare December 20, 2024 11:48
@jesperengstrom jesperengstrom merged commit 0d6b1b9 into develop Dec 20, 2024
3 checks passed
@jesperengstrom jesperengstrom deleted the fix/lxlquery-wildcard-boolean-operator branch December 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbissemattsson johanbissemattsson johanbissemattsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesperengstrom @johanbissemattsson