Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWS-265: Add search request handling #1178

Merged
merged 20 commits into from
Nov 26, 2024

Conversation

johanbissemattsson
Copy link
Contributor

@johanbissemattsson johanbissemattsson commented Nov 25, 2024

Description

Tickets involved

LWS-265

Solves

Adds search request handling for the SuperSearch component, handling debouncing, querying, cancellation of pending fetches (when fetching new data), and support for paginated data.

The component and request handling is purposefully made largely generic to support different kinds of data endpoints.

Styling is still extremely rudimentary in the lxl-web implementation!

Summary of changes

  • Add useSearchRequest for request handling
  • Add debouncing
  • Add optional transform function
  • Add support for paginated data
  • Cancel pending fetches when fetching new data
  • Add snippet prop for result items
  • Add tests
  • Add basic supersearch request handling in lxl-web
  • Update readme

@johanbissemattsson johanbissemattsson marked this pull request as ready for review November 25, 2024 16:23
Copy link
Contributor

@jesperengstrom jesperengstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment)

Otherwise a really good foundation, nice job! 🚢

@johanbissemattsson johanbissemattsson merged commit 27272fb into develop Nov 26, 2024
3 checks passed
@johanbissemattsson johanbissemattsson deleted the LWS-265-search-request-handling branch November 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants