Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWS-259: Upgrade lxl-web to Svelte 5 #1144

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

johanbissemattsson
Copy link
Contributor

@johanbissemattsson johanbissemattsson commented Nov 4, 2024

Description

Tickets involved

LWS-259

Solves

Upgrades lxl-web to Svelte 5. No components are migrated to the new runes syntax to lessen the scope of this PR.

Summary of changes

  • Upgrade to Svelte 5
  • Use estree-walker as walk is no longer exported from svelte-compiler
  • Resolve warning regarding self-closing HTML tags for non-void elements
  • Resolve mdsvex layout relative path problem with monorepo and VSCode
  • Fix missing popovers after Svelte upgrade

@johanbissemattsson johanbissemattsson changed the title Chore/lxl web svelte 5 LWS-259: Upgrade lxl-web to Svelte 5 Nov 4, 2024
@johanbissemattsson johanbissemattsson marked this pull request as ready for review November 4, 2024 16:03
@jesperengstrom
Copy link
Contributor

Getting a load of these in the console relating to the popover component.
Skärmavbild 2024-11-04 kl  17 10 30

Other than that - seems to be working as before!

Copy link
Contributor

@jesperengstrom jesperengstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌟

@johanbissemattsson johanbissemattsson merged commit 519db86 into develop Nov 5, 2024
2 checks passed
@johanbissemattsson johanbissemattsson deleted the chore/lxl-web-svelte-5 branch November 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants