Matomo tracker load fix #1127
Merged
Matomo tracker load fix #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves
I've discovered a bug in the Matomo implementation. Sometimes
initMatomois called before the matomo.js script has loaded, causing the whole thing to fail silently and nothing is logged (until a page reload - when the script is probably cached). Try it out by opening a fresh incognito tab and visit beta-dev a couple of times.Summary of changes
We need to
setContextduring component initialization, but we can update it with the tracker when the script is ready. Here using anon:loadhandler. Also doing atrackPageViewin the init function so we don't miss to track the first page load.