Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWS-231: Cookie consent #1126

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

jesperengstrom
Copy link
Contributor

@jesperengstrom jesperengstrom commented Oct 16, 2024

Description

Tickets involved

LWS-231

Solves

Adds cookie consent functionality using vanilla-cookieconsent package.

Using the same implementation as Tidningar, i.e if user opts out of analytical cookies, we don't track them at all.

To test:

  • No post requests to matomo.php are being made until user accepts all cookies.
  • Post requests to matomo.php are made when user consents to all cookies.
  • Requests to matomo.php stops when user redacts their consent (using the settings link in the footer) and matomo cookies (_pk*) are cleared.

Summary of changes

Add cookie package, cookie component & translation files.

@jesperengstrom jesperengstrom marked this pull request as ready for review October 17, 2024 10:48
Copy link
Contributor

@johanbissemattsson johanbissemattsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems to work as intended! 🌟

@jesperengstrom jesperengstrom merged commit 0d758bd into develop Oct 23, 2024
2 checks passed
@jesperengstrom jesperengstrom deleted the feature/LWS-231-cookie-consent branch October 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants