LWS-244: Filter sort #1103
Merged
LWS-244: Filter sort #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olovy
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Nice! LGTM!
Some things I would like see in a later PR:
- Suitable default sort order for each facet group (should maybe be a backend config?)
Things to discuss later:
- Some/top/all? facet groups should be expanded by default?
- Some facet groups might work better as top N + alphabetically, e.g. Language: Swedish, English, German, Afrikaans, Akkandian, Albanian...
I actually had this implemented ('special' sorting for groups was a var in the constants file) but it was then removed in discussion with Ebou since users can achieve the same thing if they want to. Don't know if that is a correct conclusion. Let's merge this for testing and see what can be improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-244
Solves
Allowing the user to sort individual filter groups as well as some general changes to facet/filter section.
Summary of changes
Each filter group (with the exception of
other) now gets a sort select element on expansion. The sorting is done in the client, and is persisted after navigation/reload by setting a cookie using thejs-cookiepackage. By using cookies (and not localStorage) the setting is available during SSR, which is probably also needed with future user settings until we save them in a db.The cookie is retrieved in the hooks
handlefunction and passed to the frontend in the serverloadfunctions. Quite the roundtrip, but i've not come up with a more elegant way to do it...Other changes
details/summaryelements for the filter panel (in line with rest of the app) to allow expanding the sections without js enabled.discriminatortext which i've made darker.