LWS-210: Filter libraries #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-210
Solves
Adds an input to find libraries in the holdings list.
Works/looks very similar to the search in the facet panel, with some differences:
The search string is used to create a filtered list, rather than sent to the individual components. This felt like a cleaner way to do it + we can display 'no hits'. Trade-of is components are unmounted/mounted on search, meaning we have to perform the api call again if re-displayed, re-expanded.
The search is matched anywhere in the string (
indexOf) to allow searching for sigel, for example.ATM the search string remains in the input if panel is closed and re-opened. Don't know if that's good or bad?
Summary of changes
DecoratedHolderobjdisplayedHolders/filteredHolders