Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block id.kb.se and libris.kb.se datasets from being edited #1082

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

olovy
Copy link
Contributor

@olovy olovy commented Aug 5, 2024

Do a simple hardcoded check for dataset URI prefixes for now. Until we have decided how to specify this in backend. See for example EntityContainers for Concepts.

Description

Tickets involved

LXL-4254

Solves

Prevents accidental editing of language, library and other definitions from externally defined datasets.
There is still no access control mechanism for these in backend. This does not guard against malicious changes.

Do a simple hardcoded check for dataset URI prefixes for now.
Until we have decided on an how to specify this in backend.
See for example EntityContainers for Concepts.
Copy link
Member

@andersju andersju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olovy olovy merged commit 77db7d4 into develop Aug 5, 2024
1 check passed
@olovy olovy deleted the feature/lxl-4254-block-dataset-editing branch August 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants