Skip to content

Commit

Permalink
Add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@jesperengstrom
jesperengstrom committed Dec 17, 2024
1 parent d2c8e64 commit dc204c3
Show file tree
Hide file tree
Showing 2 changed files with 199 additions and 4 deletions.
11 changes: 7 additions & 4 deletions lxl-web/src/lib/utils/getLabelsFromMapping.svelte.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,14 @@ function iterateMapping(
} else if (el.property === key) {
keyLabel = el.label;
const isLinked = !!el.display?.['@id'];
// only use atomic ranges for linked values
if (isLinked && el.displayStr) {
valueLabel = el.displayStr;
if (isLinked) {
if (el.displayStr) {
// only use atomic ranges for linked values
valueLabel = el.displayStr;
}
// only show remove btn for pills that can't be edited
removeLink = el.up?.['@id'];
}
removeLink = el.up?.['@id'];
}
});
}
Expand Down
192 changes: 192 additions & 0 deletions lxl-web/src/lib/utils/getLabelsFromMapping.test.ts
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
import { describe, it, expect } from 'vitest';
import getLabelsFromMapping from './getLabelsFromMapping.svelte';
import type { DisplayMapping } from '$lib/types/search';

describe('getLabelsFromMapping', () => {
it('it returns labels when supplied with page mappings', () => {
const labels = getLabelsFromMapping('genreForm', 'saogf:Romaner', pageMapping, null);
expect(labels.keyLabel).toBe('Genre/form');
expect(labels.valueLabel).toBe('Romaner');
});

it('it returns labels when supplied with suggest mappings', () => {
const labels = getLabelsFromMapping('genreForm', 'saogf:Romaner', null, suggestMapping);
expect(labels.keyLabel).toBe('Genre/form');
expect(labels.valueLabel).toBe('Romaner');
});

it('it returns suggest labels when supplied with both mappings', () => {
const labels = getLabelsFromMapping('SPRÅK', 'lang:swe', pageMapping, suggestMapping);
expect(labels.keyLabel).toBe('Språk');
expect(labels.valueLabel).toBe('Svenska');
});

it('it returns undefined values when no correct key match', () => {
const labels = getLabelsFromMapping('invalid', 'saogf:Romaner', pageMapping, suggestMapping);
expect(labels.keyLabel).toBe(undefined);
expect(labels.valueLabel).toBe(undefined);
});

// TODO run test when value matching is done properly
// it('it returns no value label when value does not match', () => {
// const labels = getLabelsFromMapping('genreForm', 'saogf:SomeInvalidTerm', pageMapping, null);
// expect(labels.keyLabel).toBe('Genre/form');
// expect(labels.valueLabel).toBe(undefined);
// });

it('does not return value labels for unlinked items', () => {
const labels = getLabelsFromMapping('ÅR', '2023', pageMapping, suggestMapping);
expect(labels.keyLabel).toBe('Utgivningsår');
expect(labels.valueLabel).toBe(undefined);
});

it('does not return a removelink for unlinked items', () => {
const labels = getLabelsFromMapping('ÅR', '2023', pageMapping, suggestMapping);
expect(labels.removeLink).toBe(undefined);
});

it('does not return a removelink when using suggest mappings', () => {
const labels = getLabelsFromMapping('genreForm', 'saogf:Romaner', null, suggestMapping);
expect(labels.removeLink).toBe(undefined);
});

it('returns a removelink when using page mappings', () => {
const labels = getLabelsFromMapping('genreForm', 'saogf:Romaner', pageMapping, null);
expect(labels.removeLink).toBe('/find?_i=sommar&_q=sommar+%C3%85R:2023&_limit=20&_spell=true');
});
});

// sommar genreForm:"saogf:Romaner" ÅR:2023
const pageMapping: DisplayMapping[] = [
{
children: [
{
'@id': 'https://id.kb.se/vocab/textQuery',
display: 'sommar',
displayStr: 'sommar',
label: 'Fritextsökning',
property: 'textQuery',
operator: 'equals',
up: {
'@id': '/find?_i=&_q=genreForm:%22saogf:Romaner%22+%C3%85R:2023&_limit=20&_spell=true'
}
},
{
'@id': 'https://id.kb.se/vocab/genreForm',
display: {
'@id': 'https://id.kb.se/term/saogf/Romaner',
'@type': 'GenreForm',
_display: [
{
prefLabel: 'Romaner',
_label: 'föredragen benämning'
}
],
_style: ['link', 'pill'],
_label: 'Genre/form'
},
displayStr: 'Romaner',
label: 'Genre/form',
property: 'genreForm',
operator: 'equals',
up: {
'@id': '/find?_i=sommar&_q=sommar+%C3%85R:2023&_limit=20&_spell=true'
}
},
{
'@id': 'https://id.kb.se/vocab/yearPublished',
display: '2023',
displayStr: '2023',
label: 'Utgivningsår',
property: 'ÅR',
operator: 'equals',
up: {
'@id': '/find?_i=sommar&_q=sommar+genreForm:%22saogf:Romaner%22&_limit=20&_spell=true'
}
}
],
operator: 'and',
up: {
'@id': '/find?_i=&_q=*&_limit=20&_spell=true'
}
}
];

// sommar genreForm:"saogf:Romaner" ÅR:2023 SPRÅK:"lang:swe"
const suggestMapping: DisplayMapping[] = [
{
children: [
{
'@id': 'https://id.kb.se/vocab/textQuery',
display: 'sommar',
displayStr: 'sommar',
label: 'Fritextsökning',
property: 'textQuery',
operator: 'equals',
up: {
'@id':
'/find?_i=&_q=genreForm:%22saogf:Romaner%22+%C3%85R:2023+SPR%C3%85K:%22lang:swe%22&_limit=10'
}
},
{
'@id': 'https://id.kb.se/vocab/genreForm',
display: {
'@id': 'https://id.kb.se/term/saogf/Romaner',
'@type': 'GenreForm',
_display: [
{
prefLabel: 'Romaner',
_label: 'föredragen benämning'
}
],
_style: ['link', 'pill'],
_label: 'Genre/form'
},
displayStr: 'Romaner',
label: 'Genre/form',
property: 'genreForm',
operator: 'equals',
up: {
'@id': '/find?_i=sommar&_q=sommar+%C3%85R:2023+SPR%C3%85K:%22lang:swe%22&_limit=10'
}
},
{
'@id': 'https://id.kb.se/vocab/yearPublished',
display: '2023',
displayStr: '2023',
label: 'Utgivningsår',
property: 'ÅR',
operator: 'equals',
up: {
'@id':
'/find?_i=sommar&_q=sommar+genreForm:%22saogf:Romaner%22+SPR%C3%85K:%22lang:swe%22&_limit=10'
}
},
{
'@id': 'https://id.kb.se/vocab/language',
display: {
'@id': 'https://id.kb.se/language/swe',
'@type': 'Language',
_display: [
{
prefLabel: 'Svenska',
_label: 'föredragen benämning'
}
],
_label: 'Språk'
},
displayStr: 'Svenska',
label: 'Språk',
property: 'SPRÅK',
operator: 'equals',
up: {
'@id': '/find?_i=sommar&_q=sommar+genreForm:%22saogf:Romaner%22+%C3%85R:2023&_limit=10'
}
}
],
operator: 'and',
up: {
'@id': '/find?_i=&_q=*&_limit=10'
}
}
];

0 comments on commit dc204c3

Please sign in to comment.