Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution as alternative to hasTitle on Work chips #338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

oBlissing
Copy link
Contributor

Works quite nicely, but I would like some opinions on this before going ahead.

@klngwll
Copy link
Contributor

klngwll commented Nov 5, 2021

Works quite nicely, but I would like some opinions on this before going ahead.

The title and the (primary) contributor should be able to be viewed at the same time. It is an issue for the next sprint :)

@oBlissing
Copy link
Contributor Author

oBlissing commented Nov 5, 2021

The title and the (primary) contributor should be able to be viewed at the same time. It is an issue for the next sprint :)

Ok. Yes, maybe this is the wrong approach then. The main point of this was to have something for the Works without title, but we don't have to add that as an alternateProperty, we can just add contribution the normal way.

@niklasl
Copy link
Member

niklasl commented Jan 17, 2022

Should we close this, or rework it somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants