-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DON'T MERGE] mGBA updates, Game Boy support #37
Conversation
Qt: Fix software renderer scaling
Can we merge this thing already now or how long is this going to take? You havent even taken care of the merge conflict and yet this thing has stayed in here for months. Must I absolutely do everything here by myself? If you say 'dont merge', at least take the initiative by yourself to get it merge ready then or else nothing happens. |
He is only honoring the author's wishes by not merging till the new features are ready |
That was May 8, and honestly, we need to stay up to date. Either that or we rebrase the repo altogether. |
There's no merge conflict, I fix that every time I merge it, I can say it's working fine at least on Linux. Endrift said to not merge it, but if you are in the rush to merge, then do that. |
In a rush to merge? this goddamn thing has been in wait here since May. You call this a 'rush', being months and months out of date? |
Merge it then I guess. |
Eh, I need to rebase against the new commits from the fork right? I forgot that. |
So what do we do here? Just make a new fork and transfer the static Makefile over? |
No, I'll try to sherry pick that cheevos commits |
I think it's better wait endrift implement cheevos, then we rollback some commits in master to be able merge this PR
|
Alright, lets close this then. |
Let's wait for the next release. Making a PR just to aware people to not waste time merging & fixing.
I tested it only on Linux.