Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake build on FreeBSD #1108

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix CMake build on FreeBSD #1108

merged 1 commit into from
Oct 15, 2024

Conversation

botovq
Copy link
Contributor

@botovq botovq commented Oct 15, 2024

FreeBSD's libc has a stub implementation of pthread_once() that returns ENOSYS and doesn't seem to call the init routine. You need to link with pthread for this to work. This PR does this and fixes regress failures for CMake builds on this platform. This likely never worked.

FreeBSD's libc has a stub implementation of pthread_once() that returns
ENOSYS and doesn't seem to call the init routine. You need to link with
pthread for this to work.  This PR does this and fixes regress failures
for CMake builds on this platform.  This likely never worked.
@botovq
Copy link
Contributor Author

botovq commented Oct 15, 2024

There doesn't seem to be a supported way of runing a FreeBSD CI on github. Maybe there's something like the Solaris CI that could be done here? Otherwise we'd need to self-host something.

@joshuasing, could you take a look? I twould be great to have some coverage for both autoconf and cmake builds on FreeBSD.

@botovq botovq added the CI label Oct 15, 2024
@joshuasing
Copy link
Member

joshuasing commented Oct 15, 2024

There doesn't seem to be a supported way of runing a FreeBSD CI on github. Maybe there's something like the Solaris CI that could be done here? Otherwise we'd need to self-host something.

@joshuasing, could you take a look? I twould be great to have some coverage for both autoconf and cmake builds on FreeBSD.

@botovq Yep! There seems to be a GitHub Action that runs a FreeBSD VM (similar to the Solaris CI we currently have, and the action is by the same person it seems): https://github.com/marketplace/actions/freebsd-vm

I think this would work, so I'll test it out and create a pull request to add a workflow

@botovq botovq merged commit d8350cf into libressl:master Oct 15, 2024
47 checks passed
@botovq botovq deleted the freebsd-cmake branch October 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants