-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append version to dll on CMake #1084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this makes sense to me. I'm fine with doing this, but I would like to give @busterb some time to comment.
This seems like the right way to do this. Thanks @ikspress This does bump our minimum CMake version to 3.27, which I'm fine with https://cmake.org/cmake/help/latest/prop_tgt/DLL_NAME_WITH_SOVERSION.html To get the unversioned behavior, a user can set CMAKE_PLATFORM_NO_VERSIONED_SONAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failures in the CI re-run are just from this needing a rebase for changes in master openbsd branch since it was submitted.
This CMake version is so new (2023-07-17), that this new requirement breaks Ref: https://github.com/curl/curl-for-win/actions/runs/11079065050/job/30787458202#step:3:12090 Anything below that would be nice, but I find that even 3.20.0 is too edit: something like could work to limit this to new CMake versions and perhaps keep the old behavior for older ones: if(NOT CMAKE_VERSION VERSION_LESS 3.27.0)
set_target_properties(ssl PROPERTIES DLL_NAME_WITH_SOVERSION TRUE)
endif() |
Suggested by Viktor Szakats in libressl#1084
Fixes #1083