Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added username and password to reqired #3

Closed
wants to merge 4 commits into from

Conversation

ComlOnline
Copy link
Contributor

Need to build as final check nothing broke.

@ComlOnline ComlOnline self-assigned this Nov 21, 2017
@brain0
Copy link
Contributor

brain0 commented Dec 18, 2017

Why would this be desired? librespot works just well in "discovery mode" without giving a username or password.

@ComlOnline
Copy link
Contributor Author

From what I understood, and found in testing librespot needs a premium account signed into it for it to work. I may be wrong however so will check that this weekend, Thanks for making me check!

@ComlOnline ComlOnline added the bug label Dec 19, 2017
@ComlOnline
Copy link
Contributor Author

@brain0 What version of librespot are you using?

@brain0
Copy link
Contributor

brain0 commented Dec 19, 2017

Librespot signs itself in with your credentials as soon as you connect a spotify client to it. A premium account is still required of course, but there is no need to store the credentials on the librespot host. I am using it this way with the official Android and Linux Desktop spotify client.

I am running the latest git master of librespot.

@fossedihelm
Copy link
Contributor

Agree with @brain0. Premium account is required to use "spotify connect", otherwise you cannot use this feature. You can set username and password to librespot if you want to have the device availaible in internet (not in the same network). In my honest opinion there're no reasons to require this information as mandatory.

@ComlOnline
Copy link
Contributor Author

Thanks for clearing that up @brain0 and @fossedihelm I misunderstood how that aspect of it worked. I may add that to the readme to make it clearer.

@ComlOnline ComlOnline closed this Dec 22, 2017
ComlOnline added a commit that referenced this pull request Jan 8, 2018
I jumped the gun
@ComlOnline ComlOnline deleted the Change-of-required-options branch January 23, 2018 00:24
sashahilton00 pushed a commit that referenced this pull request Feb 14, 2018
michaelherger referenced this pull request in michaelherger/librespot Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants