Easier mocking of platforms #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photovoltex
force-pushed
the
easier-platform-adjusting
branch
from
2e81d58 to
7913dad
Compare
|
Looks good. I think an "Added" changelog entry would make sense, to hint developers to its existence. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1344, it is quite a hassle to figure out how to test or adjust librespot to work on other platforms, like on mobile. By moving the
OSconstant and theos_versionintoconfig.rswe have a single location where we can adjust these values and mock the different platforms.I'm unsure if a changelog entry is necessary or would make sense for this change, so i didn't create one yet.