Updated AsyncWorker (and defined AsyncProcessor) so that we get back … #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Futures for processed tasks. Those futures can then be used to block on and wait if desired. Exceptions during async processing are now also caught and logged, rather than causing the thread to die and leaving us in a bad state.
|
I think there's still the issue that the task will be interrupted when the worker is closed. The problem originated from #155 where I need to send an event before shutting everything down, if it's not quick enough an exception will be thrown which is not a big deal because the request itself has been sent already. I was just wondering whether there was a way to get around it. |
…or a graceful shutdown.
|
Changed to a simpler Executor based approach. This means when you call close it will wait 1 minute for currently running tasks to complete. |
devgianlu
reviewed
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Futures for processed tasks. Those futures can then be used to block on and wait if desired.
Exceptions during async processing are now also caught and logged, rather than causing the thread to die and leaving us in a bad state.