Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the PlayerViewModel, so that each fragment or activity where an exoplayer is used has its own properly scoped exoplayer. The result is that an exoplayer is created when the viewmodel of a fragment that needs a player is created and destroyed when the viewmodel is. The exoplayer is no longer recreated upon orientation change.
This means that media keeps playing without interruptions upon orientation change, fixing #5754 (comment)
The exoplayer no longer lives inside the player fragment or in the activity scoped viewmodel.