fix: change DeArrow title submission default #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting when trying to run klint |
|
No worries, you can ignore ktlint. |
Bnyro
reviewed
Apr 17, 2024
Comment on lines
66
to
68
|
|
||
| binding.titleCheckbox.setOnCheckedChangeListener(onChecked) | ||
| binding.thumbnailTimeCheckbox.setOnCheckedChangeListener(onChecked) |
There was a problem hiding this comment.
We already set onCheckedChangeListener's above, it's not possible to add multiple checked change listeners. Hence this results in none of the text input fields being usable anymore.
Bnyro
force-pushed
the
dearrow-contrib-default
branch
from
bbe224c
to
467fe10
Compare
Bnyro
force-pushed
the
dearrow-contrib-default
branch
from
467fe10
to
58e901d
Compare
Bnyro
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Ok" button disabled until at least one option is checked