-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rewrite comments fragments using Paging library #5589
refactor: Rewrite comments fragments using Paging library #5589
Conversation
d82eafb
to
0440a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed 3 small regressions:
- The "back" button on the top left is no longer visible when visiting the comment replies fragment, as it's been before the changes.
- There's no loading indicator when opening the replies of a comment / it's positioned at the bottom sometimes instead of the top.
- The channel avatars of the commentors/repliers are having the same issue as in refactor: Rewrite search functionality using Paging #5528 (comment).
f19164c
to
99099a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment fragment works very well now, thank you for looking into my comments!
I noticed one small visual issue when opening the replies fragment when the comment has a lot of issues - it seems like the main comment is duplicated - once at the bottom of the replies and once at the top. When scrolling up again, the duplicated comment at the bottom vanishes. It looks like the layout isn't properly re-created here when the comments are loaded?
I'm not really familiar with the paging library, so I can't really tell what's going on.
That's because the parent comment is first displayed before the replies are loaded into the adapter. This guide should help with understanding the paging library. |
In single-answer comments, you must go back and reload the answer to see the answer. Do you have a solution? |
Changing |
Improve the comment and comment replies fragments by using the paging library.