Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify ContentFilter toggling #5544

Merged
merged 4 commits into from
Jan 27, 2024
Merged

refactor: Simplify ContentFilter toggling #5544

merged 4 commits into from
Jan 27, 2024

Conversation

Isira-Seneviratne
Copy link
Collaborator

No description provided.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Simplify_ContentFilter branch 2 times, most recently from 947b1f8 to 0ef64ee Compare January 23, 2024 23:42
@Bnyro
Copy link
Member

Bnyro commented Jan 24, 2024

Please also change the prederence key value of "SELECTED_FEED_FILTERS" to avoid crashes when updating the app.

@Isira-Seneviratne
Copy link
Collaborator Author

Please also change the prederence key value of "SELECTED_FEED_FILTERS" to avoid crashes when updating the app.

Wasn't the content filter functionality introduced after the 0.21.1 release? In that case, there should be no issue as it's new anyway.

@Bnyro
Copy link
Member

Bnyro commented Jan 25, 2024

Yes, but there are some people using the debug builds for testing, so it will cause issues for them.

@Bnyro
Copy link
Member

Bnyro commented Jan 26, 2024

I would have just changed the preference key so that the pref is being reset for all users - but that's fine with me too 👍

Maybe we should also add a "TODO" or some comment about removing this "migration" code some time in the future, because the migration is probably needed by a few people using debug builds and can be removed in some months.

@Isira-Seneviratne Isira-Seneviratne merged commit 9b963a3 into libre-tube:master Jan 27, 2024
3 of 4 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Simplify_ContentFilter branch January 27, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isira-Seneviratne @Bnyro