Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Rich caption rendering" setting #5371

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

RafaelsRamos
Copy link
Contributor

Adds a new setting - Rich caption rendering (false by default) under Settings > Player > Appearance.

Showcase

sample.mp4
  • Translations;

Notes

  • This setting does not apply mid-video. e.g. If we are watching a video, and change the setting, the changes only reflect once we open a new video. The settings I tested had the same behaviour, but I would like to confirm that is expected, or if I'm missing something;
  • I added a new translation under the id - rich_caption_rendering. I don't know if there is anything else I must do regarding this addition.

closes #5306

@IndusAryan

This comment was marked as resolved.

@RafaelsRamos
Copy link
Contributor Author

RafaelsRamos commented Dec 21, 2023

The reason we opted for the setting is the issue reported on #5306.

@Bnyro
Copy link
Member

Bnyro commented Dec 21, 2023

Please also add a "android:summary" to the preference which explains a bit what the preference actually does, like "Render web captions style (position, color, italics, ...)".

@Bnyro Bnyro changed the title Add setting - "Rich caption rendering" feat: add "Rich caption rendering" setting Dec 21, 2023
@RafaelsRamos
Copy link
Contributor Author

Went with "Render web captions for a more rich and customized experience.". Do you guys agree?

On another note, I would like to review these settings' texts since I see that some descriptions have '.' in the end, others don't, etc. Just a walkaround for consistency. If you think is best I could do that review in this PR, but I would prefer to do that in a different one.

@Bnyro
Copy link
Member

Bnyro commented Dec 21, 2023

Went with "Render web captions for a more rich and customized experience.". Do you guys agree?

Sounds good 👍

On another note, I would like to review these settings' texts since I see that some descriptions have '.' in the end, others don't, etc. Just a walkaround for consistency. If you think is best I could do that review in this PR, but I would prefer to do that in a different one.

That'd be better if we do that in a different PR, yes 👍

@Bnyro Bnyro merged commit f60375a into libre-tube:master Dec 21, 2023
3 of 4 checks passed
@maboroshin
Copy link

maboroshin commented Dec 22, 2023

Render web captions for a more rich and customized experience.

The above would not be a sufficient description of the setting. This text is meant to solve the problem if it is on. Is the following statement also needed?

```Turn off the subtitles when they are on the side.``

@RafaelsRamos RafaelsRamos deleted the rafa/5306 branch January 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange placement of subtitles
4 participants