Fix missing SUBSCRIBE and refactor #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depend on latest commits on libp2p/rust-libp2p#3625 more specifically libp2p/rust-libp2p@b572895 resolving the missing SUBSCRIBE message previously not send by a rust-libp2p server. Additional refactorings: - Use clap to parse command line arguments. Among other things gives us nice help text and better error messages. - Depend on `libp2p-webrtc` directly as we will remove the re-export from `libp2p`. - Use `futures-timer` to send `Hello World` on a 2 second interval instead of on each `SwarmEvent`. - Redo logging on various levels (warn, info, debug).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Merged |
maschad
added a commit
that referenced
this pull request
Mar 29, 2023
maschad
added a commit
that referenced
this pull request
Mar 29, 2023
thomaseizinger
pushed a commit
to thomaseizinger/universal-connectivity
that referenced
this pull request
Sep 22, 2023
2color
added a commit
that referenced
this pull request
Sep 17, 2024
* feat: direct messages (#5) * chore: use Libp2pType * feat: add direct messaging as a custom service * chore: move init of directmessage handler * fix: add await to dm receive * chore: small simplification (#6) * chore: small simplification * chore: remove from field which can be derived --------- Co-authored-by: Daniel N <[email protected]> * chore: signals * chore: remove menu, add popover * chore: move markAsRead to hook * chore: wrap dm receive in try catch --------- Co-authored-by: Daniel Norman <[email protected]> Co-authored-by: Daniel N <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating as pull request until libp2p/github-mgmt#140 is merged.
Depend on latest commits on libp2p/rust-libp2p#3625 more specifically
libp2p/rust-libp2p@b572895 resolving the missing SUBSCRIBE message previously not send by a rust-libp2p server.
Additional refactorings:
libp2p-webrtcdirectly as we will remove the re-export fromlibp2p.futures-timerto sendHello Worldon a 2 second interval instead of on eachSwarmEvent.