feat(interop): add js-libp2p v0.44 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy of `multidim-interop/impl/js/v0.42` plus version adjustments + reenable WebRTC (see libp2p#160).
|
@MarcoPolo @achingbrain can either of you give this a review? |
|
Friendly ping @MarcoPolo and @achingbrain. Mind giving this a review? |
|
Thanks @mxinden, is there something you need for this? I wanted to merge libp2p/js-libp2p#1615 first, then add v0.44 to reference that impl. |
|
I want to make sure we don't introduce a regression between Rust and JS in the WebRTC direct transport implementation. We are currently not testing Rust against JS on WebRTC Direct, see #160. libp2p/js-libp2p#1615 seems like the right way forward. In the meantime I am in favor of merging here. Any objections @MarcoPolo? |
MarcoPolo
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of
multidim-interop/impl/js/v0.42plus version adjustments + reenable WebRTC Direct (see #160).