Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build rust-libp2p during interop test run #343

Closed
achingbrain opened this issue Jan 24, 2024 · 4 comments · Fixed by #342
Closed

Cannot build rust-libp2p during interop test run #343

achingbrain opened this issue Jan 24, 2024 · 4 comments · Fixed by #342

Comments

@achingbrain
Copy link
Member

I think rust might need updating in the ping interop tests? It's currently breaking builds.

#15 161.2 error: package `libp2p-identity v0.2.8` cannot be built because it requires rustc 1.73.0 or newer, while the currently active rustc version is 1.67.0

https://github.com/libp2p/js-libp2p/actions/runs/7638820411/job/20810985299?pr=2372

cc @mxinden @thomaseizinger
achingbrain added a commit to libp2p/js-libp2p that referenced this issue Jan 24, 2024
@achingbrain
chore: temporarily disable interop tests
bc78e2f 
Disable tests until rust-libp2p builds again.

Refs: libp2p/test-plans#343
@achingbrain achingbrain mentioned this issue Jan 24, 2024
Merged
3 tasks
achingbrain added a commit to libp2p/js-libp2p that referenced this issue Jan 24, 2024
@achingbrain
chore: temporarily disable interop tests (#2374)
72f0e09 
Disable tests until rust-libp2p builds again.

Refs: libp2p/test-plans#343
@mxinden
Copy link
Member

mxinden commented Jan 24, 2024

I believe @thomaseizinger has already been looking into this: #342

@achingbrain
Copy link
Member Author

I spotted that but the build error it fixes seems different? Though I guess the fix is probably going to be the same.

@thomaseizinger
Copy link
Contributor

Yeah the underlying issue is I believe a bug in cargo-chef: LukeMathWalker/cargo-chef#252

@thomaseizinger thomaseizinger mentioned this issue Jan 24, 2024
Merged
achingbrain added a commit to libp2p/js-libp2p that referenced this issue Jan 25, 2024
@achingbrain
chore: re-enable interop tests
803081b 
libp2p/test-plans#343 is fixed so revert #2374
@achingbrain achingbrain mentioned this issue Jan 25, 2024
Merged
3 tasks
achingbrain added a commit to libp2p/js-libp2p that referenced this issue Jan 25, 2024
@achingbrain
chore: re-enable interop tests (#2376)
c9ed1c7 
libp2p/test-plans#343 is fixed so revert #2374
@achingbrain
Copy link
Member Author

That's fixed it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update rust-v0.52 hash to fix build error libp2p/test-plans
3 participants
@achingbrain @thomaseizinger @mxinden