Remove bytes dependency.
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is the worry, that streams which do not consume their buffers in a timely manner prevent `BytesMut` from reusing their storage space, instead forcing it to allocate more memory. This PR removes `bytes` completely and instead uses `Vec<u8>`s. The reclamation of storage is left to the allocator. While at it we also remove the `BufWriter` from `Io`. Often client code already uses buffers and always adding another buffer layer seems misguided. After all clients may always provide `Connection::new` with a `BufWriter` type.
romanb
approved these changes
Mar 18, 2020
| pub(crate) fn len(&self) -> Option<usize> { | ||
| self.seq.iter().fold(Some(0), |total, x| { | ||
| total.and_then(|n| n.checked_add(x.len())) | ||
| }) | ||
| } | ||
|
|
||
| pub(crate) fn push(&mut self, x: Bytes) { | ||
| /// Add another chunk of bytes to the end. | ||
| pub(crate) fn push(&mut self, x: Vec<u8>) { |
There was a problem hiding this comment.
Given that this entire module is private to the crate, is there a need for pub(crate) in this module at all, as opposed to just pub? Or is it a stylistic choice to always use pub(crate) in private modules?
There was a problem hiding this comment.
Yes, while those items could be made public, given that the module is private, I like to think it makes it easier to read the code when one can see directly that an item is not part of the public API without having to look outside the current reading context how the whole module is used.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change is the worry, that streams which do not consume their buffers in a timely manner prevent
BytesMutfrom reusing their storage space, instead forcing it to allocate more memory.This PR removes
bytescompletely and instead usesVec<u8>s. The reclamation of storage is left to the allocator. As a side effect, all instances ofunsafeare removed, so if merged, #66 can be considered done.While at it we also remove the
BufWriterfromIo. Client code often already uses buffers and always adding another buffer layer seems misguided. If desired clients may always provideConnection::newwith aBufWritertype.