Merge pull request #115 from romanb/v0.8.1

v0.8.1

.github/workflows/rust.yml

@@ -2,9 +2,9 @@ name: Rust
 
 on:
   push:
-    branches: [ develop ]
+    branches: [ develop, master ]
   pull_request:
-    branches: [ develop ]
+    branches: [ develop, master ]
 
 env:
   CARGO_TERM_COLOR: always

CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.8.1
+
+- Avoid possible premature stream resets of streams that have been properly
+  closed and already dropped but receive window update or other frames while
+  the remaining buffered frames are still sent out. Incoming frames for
+  unknown streams are now ignored, instead of triggering a stream reset for
+  the remote.
+
 # 0.8.0
 
 - Upgrade step 4 of 4. This version always assumes the new semantics and

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "yamux"
-version = "0.8.0"
+version = "0.8.1"
 authors = ["Parity Technologies <[email protected]>"]
 license = "Apache-2.0 OR MIT"
 description = "Multiplexer over reliable, ordered connections"

src/connection.rs

@@ -715,10 +715,13 @@ impl<T: AsyncRead + AsyncWrite + Unpin> Connection<T> {
                 return Action::Update(frame)
             }
         } else if !is_finish {
-            log::debug!("{}/{}: data for unknown stream", self.id, stream_id);
-            let mut header = Header::data(stream_id, 0);
-            header.rst();
-            return Action::Reset(Frame::new(header))
+            log::debug!("{}/{}: data for unknown stream, ignoring", self.id, stream_id);
+            // We do not consider this a protocol violation and thus do not send a stream reset
+            // because we may still be processing pending `StreamCommand`s of this stream that were
+            // sent before it has been dropped and "garbage collected". Such a stream reset would
+            // interfere with the frames that still need to be sent, causing premature stream
+            // termination for the remote.
+            // See https://github.com/paritytech/yamux/issues/110 for details.
         }
 
         Action::None
@@ -782,9 +785,12 @@ impl<T: AsyncRead + AsyncWrite + Unpin> Connection<T> {
             }
         } else if !is_finish {
             log::debug!("{}/{}: window update for unknown stream", self.id, stream_id);
-            let mut header = Header::data(stream_id, 0);
-            header.rst();
-            return Action::Reset(Frame::new(header))
+            // We do not consider this a protocol violation and thus do not send a stream reset
+            // because we may still be processing pending `StreamCommand`s of this stream that were
+            // sent before it has been dropped and "garbage collected". Such a stream reset would
+            // interfere with the frames that still need to be sent, causing premature stream
+            // termination for the remote.
+            // See https://github.com/paritytech/yamux/issues/110 for details.
         }
 
         Action::None
@@ -801,9 +807,13 @@ impl<T: AsyncRead + AsyncWrite + Unpin> Connection<T> {
             return Action::Ping(Frame::new(hdr))
         }
         log::debug!("{}/{}: ping for unknown stream", self.id, stream_id);
-        let mut header = Header::data(stream_id, 0);
-        header.rst();
-        Action::Reset(Frame::new(header))
+        // We do not consider this a protocol violation and thus do not send a stream reset
+        // because we may still be processing pending `StreamCommand`s of this stream that were
+        // sent before it has been dropped and "garbage collected". Such a stream reset would
+        // interfere with the frames that still need to be sent, causing premature stream
+        // termination for the remote.
+        // See https://github.com/paritytech/yamux/issues/110 for details.
+        Action::None
     }
 
     fn next_stream_id(&mut self) -> Result<StreamId> {