Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix formatting with nightly.
Without nightly, some of our
rustfmt.toml
rules aren't applied because they are not stable yet (e.g. ourgroup_imports
rule).Our CI didn't catch it yet because it doesn't check fmt on nightly. Will fix that in a follow-up PR.
Notes & open questions
Came up in #5725 (comment).
cc @drHuangMHT you were actually correct in #5726 (comment), the items are reordered across blocks because of our rule
group_imports = "StdExternalCrate"
)Change checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksA changelog entry has been made in the appropriate crates