chore: bump crate versions and update changelogs for #5676 #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
changed the title
hanabi1224
force-pushed
the
hm/changelog-5676
branch
from
10235b0
to
489993b
Compare
|
Hmm, when I update |
jxs
reviewed
Nov 20, 2024
jxs
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Hmm, when I update
libp2p-identityversion in rootCargo.toml, I got semver CI failure, when not, I got test identity CI failure, what should I do to bump the version of this crate?
Hi, yeah it's expected with libp2p-identity due to the way it is imported. See here for a CI that has run after libp2p-identity 0.2.10 was published.
Thanks!
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps crate versions and add changelog entries for crates that are changed in #5676
Question: When should a crate version bump in the current release process? Should it be right before or right after publishing? I see most of current crate versions are published while some are not (e.g. [email protected] [email protected] and [email protected] etc.)
Notes & open questions
Change checklist