Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace async-std with tokio in autonat tests #5671

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: replace async-std with tokio in autonat tests #5671

merged 2 commits into from
Nov 18, 2024

Conversation

kamuik16
Copy link
Contributor

Description

ref #4449

Refactored autonat tests to use tokio instead of async-std.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

This pull request has merge conflicts. Could you please resolve them @kamuik16? 🙏

jxs
jxs approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jxs jxs added the send-it label Nov 18, 2024
@mergify mergify bot merged commit 8222461 into libp2p:master Nov 18, 2024
70 of 71 checks passed
@kamuik16 kamuik16 deleted the autonat branch November 19, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamuik16 @jxs