chore: refactor dcutr and gossipsub tests to use tokio instead #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Nov 5, 2024
Hey, for this one do you mind keeping this one, I'll make sure to make separate PRs for each behavior from next time. |
kamuik16
force-pushed
the
tests-dcutr-gossipsub
branch
from
27fa009
to
322b99b
Compare
jxs
changed the title
mergify
bot
dismissed
jxs’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
aah, the mergify couldn't merge becuase the branch wasn't updated so I merge the master into this one. Seems like because of it the approval was dismissed, could you approve it once again? |
no need to do that, mergify does it automatically :) |
jxs
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #4449
Refactored dcutr and gossipsub tests to use
tokioinstead ofasync-std.