fix: rendezvous identify example #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardJES
changed the title
|
Hey @jxs, is there a |
jxs
previously approved these changes
Jul 16, 2024
jxs
reviewed
Jul 16, 2024
mergify
bot
dismissed
jxs’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
|
Thanks for fixing that up @jxs. Happy to merge 🙏 |
jxs
approved these changes
Jul 16, 2024
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
This pr closes libp2p#5388 by explicitly adding the local observed address, noting this is out of protocol behaviour in non-example cases Pull-Request: libp2p#5496.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr closes #5388 by explicitly adding the local observed address, noting this is out of protocol behaviour in non-example cases
Notes & open questions
Change checklist