Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure SwarmBuilder multiplexer tests compile #4831

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: ensure SwarmBuilder multiplexer tests compile #4831

merged 2 commits into from
Nov 9, 2023

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Nov 9, 2023 •
edited by thomaseizinger
Loading

Description

Fixes #4830.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@oblique oblique mentioned this pull request Nov 9, 2023
Closed
@thomaseizinger thomaseizinger changed the title fix: SwarmBuilder multiplexer tests fix: ensure SwarmBuilder multiplexer tests compile Nov 9, 2023
thomaseizinger
thomaseizinger approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

I wonder if there is a lint for using an undefined feature ..

@thomaseizinger thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Nov 9, 2023
@mergify mergify bot merged commit b99f234 into libp2p:master Nov 9, 2023
71 checks passed
@mxinden
Copy link
Member

mxinden commented Nov 9, 2023

My bad. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwarmBuilder can not use mplex and yamux together
3 participants
@oblique @mxinden @thomaseizinger