Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add impl {In,Out}boundConnectionUpgrade for SelectUpgrade #4812

Merged
merged 8 commits into from
Nov 7, 2023
Merged

fix(core): add impl {In,Out}boundConnectionUpgrade for SelectUpgrade #4812

merged 8 commits into from
Nov 7, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Nov 6, 2023 •
edited
Loading

Description

Fixes #4810.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@gurinderu gurinderu changed the title Fix: fixed lost impls for SelectUpgrade fix(core): fixed lost impls for SelectUpgrade Nov 6, 2023
@thomaseizinger thomaseizinger changed the title fix(core): fixed lost impls for SelectUpgrade fix(core): implement {In,Out}boundConnectionUpgrade for SelectUpgrade Nov 7, 2023
thomaseizinger
thomaseizinger approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the oversight!

core/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title fix(core): implement {In,Out}boundConnectionUpgrade for SelectUpgrade fix(core): add impl {In,Out}boundConnectionUpgrade for SelectUpgrade Nov 7, 2023
@mergify mergify bot merged commit 70c968f into libp2p:master Nov 7, 2023
71 of 72 checks passed
@mxinden
Copy link
Member

mxinden commented Nov 8, 2023

Thank you @gurinderu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectMuxerUpgrade is located in the private builder module
3 participants
@gurinderu @mxinden @thomaseizinger