Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(noise): update x25519-dalek to 2.0.0 #4657

Merged
merged 4 commits into from
Oct 16, 2023
Merged

deps(noise): update x25519-dalek to 2.0.0 #4657

merged 4 commits into from
Oct 16, 2023

Conversation

kayabaNerve
Copy link
Contributor

@kayabaNerve kayabaNerve commented Oct 16, 2023

Description

Notes & open questions

Updates libp2p-noise's x25519-dalek dependency to 2.0.0.

Additionally bumps the version to:

  1. Provide a location in the CHANGELOG for the changes.
  2. Encourage a new release with this, since it doesn't appear to be used in any public API and therefore isn't a breaking change. Solely a benefit to performance and a reduction in dependency tree size.

Apologies if this was over-eager, and I'm happy to open a PR of solely the first commit.

I will note I'm unaware why this wasn't done earlier. Possibly an oversight? Or I'm missing something.

I did not add tests, yet I did run the existing test suite.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

I'm unsure why this wasn't done prior since it doesn't seem exposed in any
public API.
@kayabaNerve kayabaNerve changed the title Update libp2p-noise's x25519-dalek dependency to 2.0.0 chore: Update libp2p-noise's x25519-dalek dependency to 2.0.0 Oct 16, 2023
@thomaseizinger thomaseizinger changed the title chore: Update libp2p-noise's x25519-dalek dependency to 2.0.0 deps(noise): update x25519-dalek to 2.0.0 Oct 16, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yeah happy to release right away once merged. Just one comment!

transports/noise/Cargo.toml Show resolved Hide resolved
@thomaseizinger
Copy link
Contributor

I'm unsure why this wasn't done prior since it doesn't seem exposed in any public API.

We use dependabot and it seems I accidentally closed that one: #4355.

@kayabaNerve
Copy link
Contributor Author

Updated there too 👍

@mergify mergify bot merged commit c980b4e into libp2p:master Oct 16, 2023
@thomaseizinger
Copy link
Contributor

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants