feat(identify): include pushed Info in Event::Pushed
#4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Huseby <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
6 tasks
dhuseby
changed the title
thomaseizinger
approved these changes
Sep 20, 2023
thomaseizinger
changed the title
thomaseizinger
changed the title
Info in Event::Pushed
Co-authored-by: Thomas Eizinger <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
Signed-off-by: Dave Huseby <[email protected]>
thomaseizinger
approved these changes
Sep 21, 2023
|
This pull request has merge conflicts. Could you please resolve them @dhuseby? 🙏 |
4 tasks
|
PR #4563 hosed up this PR. I'll fix it soon, just not right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting in #3980, we make more use of the identify push protocol by actively notifying the peer when our locally supported protocols change. We emit an event (
Pushed) to the user in that case. This event however does not include what we pushed.Users might be interested in the internal changes that we push to remote peers. This patch adds the identify
Infoto thePushedvariant.Fixes #4332.
Notes & open questions
Previous broken PRs: #4335
Change checklist