feat(rendezvous): directly return error from register

[dgarus]

Description

Resolves #4070.

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

Thanks! Some minor comments and as you identified correctly, this is not backwards-compatible. That is fine because we are releasing breaking changes currently.

Can you add a changelog entry?

[dgarus]

Can you add a changelog entry?

Yes, of course.

[thomaseizinger]

Can you fix the formatting?

[dgarus]

Done

[dgarus]

@thomaseizinger
Could you please recommend me an issue?
I'd like to study the next protocol, for example, kad.

[thomaseizinger]

@thomaseizinger
Could you please recommend me an issue?
I'd like to study the next protocol, for example, kad.

Thank you!

Here are two issues that I'd consider a good fit if you want to dive into some of the protocols:

• relay: refactor stream handling away from {In,Out}boundUpgrade #4075
• swarm: Remove ConnectionHandler::Error #3591

The first one just applies to the relay and contributes to the same overarching effort that you've just worked on.

The second one is a tracking issue with multiple tasks that also contributes to making the ConnectionHandler interface easier and hopefully allows protocols to compose better by taking away the ability to just close a connection which might interrupt another protocol's work.

[dgarus]

@thomaseizinger
Could you please recommend me an issue?
I'd like to study the next protocol, for example, kad.

Thank you!

Here are two issues that I'd consider a good fit if you want to dive into some of the protocols:

• relay: refactor stream handling away from {In,Out}boundUpgrade #4075
• swarm: Deprecate ConnectionHandlerEvent::Close #3591

The first one just applies to the relay and contributes to the same overarching effort that you've just worked on.

The second one is a tracking issue with multiple tasks that also contributes to making the ConnectionHandler interface easier and hopefully allows protocols to compose better by taking away the ability to just close a connection which might interrupt another protocol's work.

Hi!
Both tasks are interesting. Think, I could start with 4075
Could you please assign it to me?

[thomaseizinger]

Could you please assign it to me?

I think you will have to interact with the issue first before Github let's me do that :)