Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(identity): remove unused file secp256r1.pk8 #3950

Merged
merged 1 commit into from
May 16, 2023
Merged

fix(identity): remove unused file secp256r1.pk8 #3950

merged 1 commit into from
May 16, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 16, 2023

Description

Introduced in #3863.

Notes & open questions

As far as I can tell, this file is not used. @drHuangMHT @thomaseizinger am I missing something?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@drHuangMHT
Copy link
Contributor

Yes, we don't need that key file, because now we use keys in libp2p/specs.

@mxinden mxinden added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels May 16, 2023
@mergify mergify bot merged commit 4fdd83e into libp2p:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @drHuangMHT